Refactor `ctx` in templates (#23105)

Before, the `dict "ctx" ...` map is used to pass data between templates.

Now, more and more templates need to use real Go context:

* #22962
* #23092


`ctx` is a Go concept for `Context`, misusing it may cause problems, and
it makes it difficult to review or refactor.

This PR contains 2 major changes:

* In the top scope of a template, the `$` is the same as the `.`, so the
old labels_sidebar's `root` is the `ctx`. So this `ctx` could just be
removed.
https://github.com/go-gitea/gitea/commit/bd7f218dce01e0fb661b23b55995f5d51b4530e8
* Rename all other `ctx` to `ctxData`, and it perfectly matches how it
comes from backend: `"ctxData": ctx.Data`.
https://github.com/go-gitea/gitea/pull/23105/commits/7c01260e1df1dcb052e1cf86ebe982bf77c4407f



From now on, there is no `ctx` in templates. There are only:

* `ctxData` for passing data
* `Context` for Go context

This commit is contained in:

wxiaoguang

2023-03-03 01:44:06 +08:00

committed by

GitHub

parent 0a9a3c2a6d

commit ce73492d6f

12 changed files with 51 additions and 51 deletions

									
										templates/repo/issue/new_form.tmpl
									
		+1
		-1
	
												View File
												
				@@ -80,7 +80,7 @@

									{{end}}

								</div>

							</div>

							{{template "repo/issue/labels/labels_sidebar" dict "root" $ "ctx" .}}

							{{template "repo/issue/labels/labels_sidebar" dict "root" $}}

							<div class="ui divider"></div>

Refactor ctx in templates (#23105)

Refactor `ctx` in templates (#23105)