Update to eslint 10 (#36925)

- Enable a few more rules, fix issues. The 2 `value` issues are
false-positives.
- Add exact types for `window.pageData` and
`window.notificationSettings`.
- peerDependencyRules for eslint-plugin-github unrestricted, the plugin
works in v10, but does not declare compatibility, pending
https://github.com/github/eslint-plugin-github/issues/680.
- Added
[eslint-plugin-de-morgan](https://github.com/azat-io/eslint-plugin-de-morgan),
no violations.

---------

Signed-off-by: silverwind <me@silverwind.io>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

web_src/js/features/citation.ts

@@ -11,7 +11,7 @@ async function initInputCitationValue(citationCopyApa: HTMLButtonElement, citati
     import(/* webpackChunkName: "citation-js-bibtex" */'@citation-js/plugin-bibtex'),
     import(/* webpackChunkName: "citation-js-csl" */'@citation-js/plugin-csl'),
   ]);
-  const {citationFileContent} = pageData;
+  const citationFileContent = pageData.citationFileContent!;
   const config = plugins.config.get('@bibtex');
   config.constants.fieldTypes.doi = ['field', 'literal'];
   config.constants.fieldTypes.version = ['field', 'literal'];

web_src/js/features/common-fetch-action.ts

@@ -99,7 +99,7 @@ export async function submitFormFetchAction(formEl: HTMLFormElement, opts: Submi
   if (formMethod.toLowerCase() === 'get') {
     const params = new URLSearchParams();
     for (const [key, value] of formData) {
-      params.append(key, value.toString());
+      params.append(key, value as string);
     }
     const pos = reqUrl.indexOf('?');
     if (pos !== -1) {

web_src/js/features/pull-view-file.ts

@@ -3,7 +3,8 @@ import {setFileFolding} from './file-fold.ts';
 import {POST} from '../modules/fetch.ts';
 
 const {pageData} = window.config;
-const prReview = pageData.prReview || {};
+// it is undefined on most pages, fortunately, when it is accessed by the related functions, it exists
+const prReview = pageData.prReview!;
 const viewedStyleClass = 'viewed-file-checked-form';
 const viewedCheckboxSelector = '.viewed-file-form'; // Selector under which all "Viewed" checkbox forms can be found
 const expandFilesBtnSelector = '#expand-files-btn';
@@ -13,11 +14,11 @@ const collapseFilesBtnSelector = '#collapse-files-btn';
 // The data used will be window.config.pageData.prReview.numberOf{Viewed}Files
 function refreshViewedFilesSummary() {
   const viewedFilesProgress = document.querySelector('#viewed-files-summary')!;
-  viewedFilesProgress.setAttribute('value', prReview.numberOfViewedFiles);
+  viewedFilesProgress.setAttribute('value', String(prReview.numberOfViewedFiles));
   const summaryLabel = document.querySelector<HTMLElement>('#viewed-files-summary-label')!;
   summaryLabel.textContent = summaryLabel.getAttribute('data-text-changed-template')!
-    .replace('%[1]d', prReview.numberOfViewedFiles)
-    .replace('%[2]d', prReview.numberOfFiles);
+    .replace('%[1]d', String(prReview.numberOfViewedFiles))
+    .replace('%[2]d', String(prReview.numberOfFiles));
 }
 
 // Initializes a listener for all children of the given html element

web_src/js/features/repo-search.ts

@@ -7,7 +7,7 @@ export function initRepositorySearch() {
 
     const params = new URLSearchParams();
     for (const [key, value] of new FormData(repositorySearchForm).entries()) {
-      params.set(key, value.toString());
+      params.set(key, value as string);
     }
     if ((e.target as HTMLInputElement).name === 'clear-filter') {
       params.delete('archived');