ibnezzoubayr/Atay-Makhzan
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up refreshViewedFilesSummary (#36868)

Browse Source 
1. Use `textContent` instead of `innerHTML` to fix
https://github.com/go-gitea/gitea/security/code-scanning/170.
2. Clean up surrounding code to remove unnecessary `if` checks on
elements that are guaranteed to exist.

---------

Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
silverwind
2026-03-08 21:49:07 +01:00
committed by GitHub
parent 80c57ec126
commit a52617b816
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web_src/js/features/pull-view-file.ts
+5 -5
View File
@@ -9,13 +9,13 @@ const viewedCheckboxSelector = '.viewed-file-form'; // Selector under which all
const expandFilesBtnSelector = '#expand-files-btn'; const expandFilesBtnSelector = '#expand-files-btn';
const collapseFilesBtnSelector = '#collapse-files-btn'; const collapseFilesBtnSelector = '#collapse-files-btn';
// Refreshes the summary of viewed files if present // Refreshes the summary of viewed files
// The data used will be window.config.pageData.prReview.numberOf{Viewed}Files // The data used will be window.config.pageData.prReview.numberOf{Viewed}Files
function refreshViewedFilesSummary() { function refreshViewedFilesSummary() {
const viewedFilesProgress = document.querySelector('#viewed-files-summary'); const viewedFilesProgress = document.querySelector('#viewed-files-summary')!;
viewedFilesProgress?.setAttribute('value', prReview.numberOfViewedFiles); viewedFilesProgress.setAttribute('value', prReview.numberOfViewedFiles);
const summaryLabel = document.querySelector('#viewed-files-summary-label')!; const summaryLabel = document.querySelector<HTMLElement>('#viewed-files-summary-label')!;
if (summaryLabel) summaryLabel.innerHTML = summaryLabel.getAttribute('data-text-changed-template')! summaryLabel.textContent = summaryLabel.getAttribute('data-text-changed-template')!
.replace('%[1]d', prReview.numberOfViewedFiles) .replace('%[1]d', prReview.numberOfViewedFiles)
.replace('%[2]d', prReview.numberOfFiles); .replace('%[2]d', prReview.numberOfFiles);
} }