Refactor auth middleware (#36848)
Principles: let the caller decide what it needs, but not let the framework (middleware) guess what it should do. Then a lot of hacky code can be removed. And some FIXMEs can be fixed. This PR introduces a new kind of middleware: "PreMiddleware", it will be executed before all other middlewares on the same routing level, then a route can declare its options for other middlewares. By the way, allow the workflow badge to be accessed by Basic or OAuth2 auth. Fixes: https://github.com/go-gitea/gitea/pull/36830 Fixes: https://github.com/go-gitea/gitea/issues/36859
This commit is contained in:
@@ -20,11 +20,12 @@ import (
|
||||
// Routes registers the installation routes
|
||||
func Routes() *web.Router {
|
||||
base := web.NewRouter()
|
||||
base.Use(common.ProtocolMiddlewares()...)
|
||||
base.BeforeRouting(common.ProtocolMiddlewares()...)
|
||||
|
||||
base.Methods("GET, HEAD", "/assets/*", public.FileHandlerFunc())
|
||||
|
||||
r := web.NewRouter()
|
||||
r.Use(common.MustInitSessioner(), installContexter())
|
||||
r.AfterRouting(common.MustInitSessioner(), installContexter())
|
||||
|
||||
r.Get("/", Install) // it must be on the root, because the "install.js" use the window.location to replace the "localhost" AppURL
|
||||
r.Post("/", web.Bind(forms.InstallForm{}), SubmitInstall)
|
||||
|
||||
Reference in New Issue
Block a user