Refactor auth middleware (#36848)

Principles: let the caller decide what it needs, but not let the
framework (middleware) guess what it should do.

Then a lot of hacky code can be removed. And some FIXMEs can be fixed.

This PR introduces a new kind of middleware: "PreMiddleware", it will be
executed before all other middlewares on the same routing level, then a
route can declare its options for other middlewares.

By the way, allow the workflow badge to be accessed by Basic or OAuth2
auth.

Fixes: https://github.com/go-gitea/gitea/pull/36830
Fixes: https://github.com/go-gitea/gitea/issues/36859

This commit is contained in:

wxiaoguang

2026-03-08 17:59:46 +08:00

committed by

GitHub

parent a0996cb229

commit 3f1ef703d5

25 changed files with 338 additions and 444 deletions

									
										modules/web/routing/requestrecord.go
									
		+1
		-1
	
												View File
												
				@@ -24,5 +24,5 @@ type requestRecord struct {

					// mutable fields

					isLongPolling bool

					funcInfo      *FuncInfo

					panicError    any

					panicError    error

				}