Don't return duplicated users who can create org repo (#22560)

- Currently the function `GetUsersWhoCanCreateOrgRepo` uses a query that
is able to have duplicated users in the result, this is can happen under
the condition that a user is in team that either is the owner team or
has permission to create organization repositories.
- Add test code to simulate the above condition for user 3,
[`TestGetUsersWhoCanCreateOrgRepo`](https://github.com/go-gitea/gitea/blob/a1fcb1cfb84fd6b36c8fe9fd56588119fa4377bc/models/organization/org_test.go#L435)
is the test function that tests for this.
- The fix is quite trivial use a map keyed by user id in order to drop
duplicates.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

This commit is contained in:

Gusted

2023-01-30 11:12:45 +01:00

committed by

GitHub

parent be315c76fb

commit 1b53a9e914

6 changed files with 28 additions and 9 deletions

									
										models/fixtures/team_user.yml
									
		+6
		
												View File
												
				@@ -93,3 +93,9 @@

				  org_id: 19

				  team_id: 6

				  uid: 31

				-

				  id: 17

				  org_id: 3

				  team_id: 14

				  uid: 2